Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent dealers from downgrading to table size leading to overcommitment #103

Closed
SharkyTheWhite opened this issue Feb 12, 2025 · 1 comment · Fixed by #108
Closed

Prevent dealers from downgrading to table size leading to overcommitment #103

SharkyTheWhite opened this issue Feb 12, 2025 · 1 comment · Fixed by #108
Assignees
@SharkyTheWhite
Labels
APPLICATION-Phase Issues that have to be done before the Application-Phase starts
Milestone
EF29

Comments

@SharkyTheWhite
Copy link
Member

When a dealership has shares/assistants and then changes their application table size, they might select a size which does not fit the amount anymore. This leads to a soft-lock where they are forced to kick out people before being able to correct the mistake.

Solution:
Prevent changing table size to an incompatible value.
@SharkyTheWhite SharkyTheWhite added the APPLICATION-Phase Issues that have to be done before the Application-Phase starts label Feb 12, 2025
@SharkyTheWhite SharkyTheWhite self-assigned this Feb 12, 2025
@SharkyTheWhite SharkyTheWhite added this to the EF29 milestone Feb 12, 2025
@SharkyTheWhite
Copy link
Member Author

SharkyTheWhite commented Feb 13, 2025 •
edited
Loading

Suggested UI change:

Disable entries in dropdown and mark them as "too small":
Image
Only if any of the entries are marked, also show an explanation below to keep visual clutter low:
Image

The program logic is only executed for disabling the input fields, not enforcing validation in the backend. The latter case is still handled like before: If you choose a size that does not work, you will be stuck at the "manage shares" view until you removed enough shares/assistants.

This should be sufficient to prevent dealers from downgrading too much by accident.

SharkyTheWhite added a commit that referenced this issue Feb 13, 2025
@SharkyTheWhite
feat(application): prevent table downgrade too small for assigned sha…
4fe52e1 
…res/assistants (#103)
@SharkyTheWhite SharkyTheWhite mentioned this issue Feb 13, 2025
Merged
Fenrikur added a commit that referenced this issue Feb 14, 2025
@SharkyTheWhite @Fenrikur
feat(application): prevent table downgrade too small for assigned sha…
ccafbe7 
…res/assistants (#103) (#108)

* feat(application): prevent table downgrade too small for assigned shares/assistants (#103)

* fix: add login redirect

---------

Co-authored-by: Fenrikur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SharkyTheWhite SharkyTheWhite

Labels
APPLICATION-Phase Issues that have to be done before the Application-Phase starts
Projects
None yet
Milestone
EF29
1 participant
@SharkyTheWhite