Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Beautify the Dealer List in the app -> Thumbnail required #26

Closed
Corborax opened this issue Aug 19, 2023 · 2 comments · Fixed by #113
Closed

Feature Request: Beautify the Dealer List in the app -> Thumbnail required #26

Corborax opened this issue Aug 19, 2023 · 2 comments · Fixed by #113
Assignees
@Fenrikur
Labels
APPLICATION-Phase Issues that have to be done before the Application-Phase starts priority
Milestone
EF29

Comments

@Corborax
Copy link
Member

If a dealer starts to submit data for the application, the thumbnail has to be required.
@Corborax Corborax added the bug Something isn't working label Feb 8, 2025
@Corborax Corborax added this to the EF29 milestone Feb 8, 2025
@Corborax Corborax added APPLICATION-Phase Issues that have to be done before the Application-Phase starts priority and removed bug Something isn't working labels Feb 11, 2025
@Corborax
Copy link
Member Author

@eurofurence/ef-dealers-den-dev We forgot this one in our meeting yesterday. I want to make sure, everyone got a thumbnail this year.

@Fenrikur
Copy link
Member

For shares, we should check if the profile is hidden or not and make the option to hide the profile part of the validation error message for this user group, as there is no need to force shares without public profile to submit a thumbnail.

@Fenrikur Fenrikur self-assigned this Feb 15, 2025
@Fenrikur Fenrikur linked a pull request Feb 15, 2025 that will close this issue
feat(profile): make thumbnail required if visible #113
Merged
@Fenrikur Fenrikur mentioned this issue Feb 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fenrikur Fenrikur

Labels
APPLICATION-Phase Issues that have to be done before the Application-Phase starts priority
Projects
None yet
Milestone
EF29
Development

Successfully merging a pull request may close this issue.

feat(profile): make thumbnail required if visible eurofurence/dealer-registration
2 participants
@Fenrikur @Corborax