Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation dialog before removal of share/assistant #69

Closed
julsteele opened this issue Mar 4, 2024 · 2 comments · Fixed by #106
Closed

Confirmation dialog before removal of share/assistant #69

julsteele opened this issue Mar 4, 2024 · 2 comments · Fixed by #106
Assignees
@SharkyTheWhite
Labels
APPLICATION-Phase Issues that have to be done before the Application-Phase starts enhancement New feature or request
Milestone
EF29

Comments

@julsteele
Copy link
Contributor

A dealer can remove shares and assistants by just clicking on the "X" button.
We should add a confirmation dialog to prevent accidental removals.
@julsteele julsteele added the enhancement New feature or request label Mar 4, 2024
@Corborax Corborax added the APPLICATION-Phase Issues that have to be done before the Application-Phase starts label Feb 8, 2025
@Corborax Corborax added this to the EF29 milestone Feb 8, 2025
@SharkyTheWhite SharkyTheWhite self-assigned this Feb 12, 2025
@SharkyTheWhite
Copy link
Member

SharkyTheWhite commented Feb 12, 2025 •
edited
Loading

Image Image

@Corborax
Copy link
Member

Looks great. Make it so!

SharkyTheWhite added a commit that referenced this issue Feb 12, 2025
@SharkyTheWhite
feat(invitees): add confirmation dialog before removing shares or ass…
3304f23 
…istants (#69)
@SharkyTheWhite SharkyTheWhite mentioned this issue Feb 12, 2025
Merged
Fenrikur added a commit that referenced this issue Feb 15, 2025
@SharkyTheWhite @Fenrikur
feat(invitees): add confirmation dialog before removing shares or ass…
c44f154 
…istants (#69) (#106)

* feat(invitees): add confirmation dialog before removing shares or assistants (#69)

* fix(test): ensure factory tables always seat at least 2

Definitely not a bodge!

* fix(invitees): fit text on seat button

* chore: fix typo

---------

Co-authored-by: Fenrikur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SharkyTheWhite SharkyTheWhite

Labels
APPLICATION-Phase Issues that have to be done before the Application-Phase starts enhancement New feature or request
Projects
None yet
Milestone
EF29
3 participants
@julsteele @Corborax @SharkyTheWhite