Fix emitting real mapping sources when null mapping comes first #4082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an ordering bug when a null mapping and a real mapping share the same
sourceIndex. If a null mapping comes first, then we'll assign it asourceIndexToSourcesIndexbut skip recording its source files in theitemsarray because of theisNullEntrycheck. When we find the real mapping later inresults, we'll skip recording its source files because of the map-okcheck.The simplest fix I can think of is flipping the order just a bit. We'll skip assigning
sourceIndexToSourcesIndexfor null mappings, so that when a real mapping comes up we'll record its sources.I'm not sure how to generate a unit test case for this, but it resolves the issue found in angular/angular-cli#29465 (comment).
Fixes #4080