Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support koa@2 #41

Open
vhpoet opened this issue Oct 11, 2016 · 21 comments
Open

Support koa@2 #41

vhpoet opened this issue Oct 11, 2016 · 21 comments

Comments

@vhpoet
Copy link

vhpoet commented Oct 11, 2016

Are you planning to support koa@2?

koa deprecated Support for generators will been removed in v3. See the documentation for examples of how to convert old middleware https://github.com/koajs/koa/tree/v2.x#old-signature-middleware-v1x
@kunyan
Copy link

kunyan commented Oct 13, 2016

@vhpoet https://github.com/kunyan/koa-cors/tree/next

@vhpoet
Copy link
Author

vhpoet commented Oct 13, 2016

@kunyan are you planning on making a PR?

@kunyan
Copy link

kunyan commented Oct 15, 2016

@vhpoet I can't push a new branch to upstream :(

@shellscape
Copy link

@kunyan can you publish this as a module, perhaps koa-cors-next ?

@kunyan
Copy link

kunyan commented Oct 19, 2016

@evert0n can you checkout a new branch named "next". and I will create a PR to it.
then you can publish a new package to npm. the user could use npm install koa-cors@next to download it

I think this way will be better.

@evert0n
Copy link
Owner

evert0n commented Oct 21, 2016

I check it out this weekend guys, I will also catch up with the other issues too, Thank you

@crunchtime-ali
Copy link

Just in time for the arrival of native async..await in Node v7.

@shellscape
Copy link

exactly. one more thing we don't have to have babel transpile

@leebenson
Copy link

@evert0n - any update to this? thanks!

@csakbalint
Copy link

@evert0n - hey, is there any possible update to this?

@kunyan
Copy link

kunyan commented Nov 15, 2016

pls use this until @evert0n push new patch

"koa-cors": "git+https://[email protected]/kunyan/koa-cors.git#next",

@leebenson
Copy link

@evert0n, could you push the new patch when you get a spare few mins please? @kunyan's instructions for loading @next are working well, but it'd be good to have an official NPM release.

@steffen
Copy link

steffen commented Jan 25, 2017

What's needed to get @kunyan's changes into an official release? Would be nice to get rid of the deprec warning. :) Thanks!

@doliver3
Copy link

It would be great to get @kunyan's change published to npm as koa-cors@next. What is the next step?

@meaku
Copy link

meaku commented Mar 2, 2017

@kunyan @evert0n how about a pull request with @kunyan's changes?

@jsonmaur
Copy link

jsonmaur commented Mar 6, 2017

Until this gets merged, you can use https://github.com/th507/koa-adapter to get rid of the deprecation warning.

@zouxuoz
Copy link

zouxuoz commented Mar 7, 2017

Guys, you can use CORS from main organization https://github.com/koajs/cors.

@amit777
Copy link

amit777 commented Jun 19, 2017

hi @evert0n I was wondering if you were planning on merging the pull request from @kunyan. Thank you both for creating this!

@bradleyayers
Copy link

Hi @evert0n would you be open to having someone else help maintain this library?

@shellscape
Copy link

@bradleyayers why not just use the module maintained by the project? https://github.com/koajs/cors

@amit777
Copy link

amit777 commented Aug 14, 2017

@shellscape that's a great q.. I can't remember why I didn't personally use it, but I vaguely remember being some reason. I should probably take a second look at it. thanks for the tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests