Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional option to export lc history of who rolled on an item #178

Open
c-p-b opened this issue Dec 10, 2019 · 3 comments
Open

Allow additional option to export lc history of who rolled on an item #178

c-p-b opened this issue Dec 10, 2019 · 3 comments

Comments

@c-p-b
Copy link

c-p-b commented Dec 10, 2019

AFAIK, RC Loot Council only exports data related to who won any item. This issue is for supporting exporting additional data related to who rolled on an item. In other words, not only do I want to export that Bob won the item, but also that Alice rolled Need on it with a note that said "Second BiS". Ideally this would include any additional information relevant to the roller, such as note supplied or roll (need, greed, minor upgrade, etc.)

@c-p-b
Copy link
Author

c-p-b commented Dec 10, 2019

@evil-morfar I'm not sure if this is actually unsupported or not. If it is not supported, I can look into making a pull request (assuming it is realistic to even implement such a feature)

@evil-morfar
Copy link
Owner

I've wanted to do that for a long time, and have already begun work on it. To clarify, I want to expand the history module to be a fully functioning "Loot Tracker" - one that can track and log every single item a player loots, along with everything that's recorded during a session.

Even doing the latter (pretty much what you seek) is a major undertaking (my current error prone implementation is already >1000 lines + another 1000 for tests), and that's basically just the same history as now using a new more expandable system.

As for an ETA, I don't know. The amount of changes this includes would warrant it to be pushed with a major release (3.0) which is my current target. v3.0 is going to be a major rework of the comms system which I hope to have ready for the next expansion (but I said that last year as well #116 (comment)).

I'm not ready to publish anything at this time - but will do so next year.

@Vladinator
Copy link

I'm glad there is a issue on this subject, because it would be very useful to see what people wanted, but didn't win as part of their history. It can help keep track of how many rolls someone did and how much they won out of all their votes. Currently there is no difference in the history logs, between people that roll and don't win, and people that don't roll (and don't win).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants