Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Additional buttons for chest slot of Amirdrassil raid armor not wroking #246

Closed
Sinnrg opened this issue Nov 20, 2023 · 6 comments
Closed
Labels

Comments

@Sinnrg
Copy link

Sinnrg commented Nov 20, 2023

Describe the bug
Additional buttons (Chest) for Amirdrassil chest armor not working, shows default selection (Need, Greed, ...) buttons. For other chest armor, from older raids, works as intended.

RCLootCouncil.zip

@Sinnrg Sinnrg added the bug label Nov 20, 2023
@evil-morfar
Copy link
Owner

Your profile doesn't show you've changed said buttons. Remember to click the "okay" button after configuring the button names/responses.

@Sinnrg
Copy link
Author

Sinnrg commented Nov 20, 2023

hm, i probably zipped before closing client didn't saved configuration. Also attaching screenshot.
RCLootCouncil (2).zip

Screenshot 2023-11-20 142019

@Sinnrg
Copy link
Author

Sinnrg commented Nov 22, 2023

so was playing around debugging, found that those chest items assigned as INVTYPE_ROBE. had to manually copy INVTYPE_CHEST section and change to INVTYPE_ROBE in RCLootCouncil.lua and it worked out. Now need fix for addon to save it as INVTYPE_CHEST AND INVTYPE_ROBE

RCLootCouncil (3).zip

@evil-morfar
Copy link
Owner

Hmm I remember dealing with that before, and thought it to be working. Will have to look into it again.
Nice find though

@Sinnrg
Copy link
Author

Sinnrg commented Nov 27, 2023

forgot to mention that i change RCLootCouncil\Core\Constants.lua
Constants.lua.txt
to lazy to zip just renamed to txt
added line
36 INVTYPE_ROBE = "Chest 2(Robe)", -- fix for INVTYPE_ROBE

evil-morfar added a commit that referenced this issue Jan 7, 2024
@evil-morfar
Copy link
Owner

Fixed in v3.10.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants