feat(runtime): support pointer equality and custom integer comparisons #752
+224
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, comparing pointer-wrapped custom integer types (e.g. `*ModeEnum`) with plain integers would fail. This change enables expressions like `Mode == 1` to work correctly when Mode is a pointer to a custom integer type. * Add pointer equality handling in code generator for "==" operator * Generate comparison cases for *T vs T and *T vs *T * Add reflection-based fallback for unknown pointer types * Support int64 coercion for custom integer type comparisons * Handle nil pointer comparisons properly * Add test coverage and example for pointer and custom type scenarios Fixes pointer equality checks and ensures consistent comparison behavior for custom integer types in expressions. Signed-off-by: Ville Vesilehto <[email protected]>
antonmedv
requested changes
Jan 27, 2025
| @@ -10,8 +10,94 @@ import ( | |||
|
|
|||
| func Equal(a, b interface{}) bool { | |||
| switch x := a.(type) { | |||
| case *uint: | |||
There was a problem hiding this comment.
We need to verify what this will not affect performance, as we significantly increased switch size.
Another point: we have a dedicated OpDeref. The runtime functions should work on "dereferenced" values. And the compiler should be able to figure out if dereference is needed before doing runtime operations.
There was a problem hiding this comment.
Forgot this from the PR description, but I ran the basic set of benchmarks from the repo root from both branches and I didn't see any performance hit. I think we could use a more specific benchmark though, simply for this case.
I'll have a look at OpDeref for #751 and make this a draft PR while doing so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, comparing pointer-wrapped custom integer types (e.g.
*ModeEnum) with plain integers would fail. This change enables expressions likeMode == 1to work correctly when Mode is a pointer to a custom integer type.Fixes pointer equality checks and ensures consistent comparison behavior for custom integer types in expressions.
Fixes #730