Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project requirements #1

Open
bjohansebas opened this issue Nov 15, 2024 · 2 comments · Fixed by #16
Open

Project requirements #1

bjohansebas opened this issue Nov 15, 2024 · 2 comments · Fixed by #16

Comments

@bjohansebas
Copy link
Member

These are the functionalities that the package should have before moving it to the Express organization:

v5:

  • Change pluralized methods
  • Change magic links in res.redirect and res.location()
  • Method change:
    • app.del -> app.delete
    • res.json(obj, status) -> res.status(status).json(obj)
    • res.jsonp(obj, status) -> res.status(status).jsonp(obj)
    • res.redirect(url, status) -> res.redirect(status, url)
    • res.send(status) -> res.sendStatus(statusCode)
    • res.sendfile() -> res.sendFile()

I don't think it's a good idea to also update the path routes since it's a very critical change and there are many cases where it may not be safe to implement.

@bjohansebas bjohansebas pinned this issue Nov 15, 2024
@bjohansebas

This comment has been minimized.

@bjohansebas
Copy link
Member Author

bjohansebas commented Jan 27, 2025

@expressjs/express-tc, I think the codemods that could be created are ready. You can try them and give us feedback.

You can run npx https://github.com/expressjs/codemod.git to execute the program

@bjohansebas bjohansebas reopened this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant