Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submenu navbar anchor active class does not get applied #1726

Open
chrisdel101 opened this issue Jan 12, 2025 · 1 comment
Open

Submenu navbar anchor active class does not get applied #1726

chrisdel101 opened this issue Jan 12, 2025 · 1 comment
Labels
bug design Change, update, or fix for site UI (not content) help wanted

Comments

@chrisdel101
Copy link
Contributor

chrisdel101 commented Jan 12, 2025

The class #navbar a.active applies styles but the active class is not being applied correctly. In this example I believe the "Guide" should be set to active, not the "Getting Started"
Screenshot 2025-01-12 at 10 16 20 AM

@chrisdel101
Copy link
Contributor Author

chrisdel101 commented Feb 3, 2025

I think is this actually operating as expected, as per the logic in the templates like:
<a href="/{{ page.lang }}/starter/installing.html"{% if page.menu == 'starter' %} class=" "{% endif %}>Getting started</a>

I think this menu would be better if the top level anchors became active when opened. The way it is now is not intuitive like the full size menu is.

@bjohansebas bjohansebas added the design Change, update, or fix for site UI (not content) label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design Change, update, or fix for site UI (not content) help wanted
Projects
None yet
Development

No branches or pull requests

2 participants