Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check module IsClosed before a function call, not after #98

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: check module IsClosed before a function call, not after #98

wants to merge 1 commit into from

Conversation

mhmd-azeez
Copy link
Collaborator

Fixes #95

As far as i can think about it, this check should be before a function call. Because it's okay for command modules to call proc_exit (and thus closing the module). From my understanding command modules are one-time use anyway

@mhmd-azeez mhmd-azeez requested a review from evacchi February 27, 2025 11:23
@mhmd-azeez mhmd-azeez requested a review from zshipko as a code owner February 27, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshipko zshipko zshipko approved these changes

@evacchi evacchi evacchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't run plugin compiled with standard go compiler
3 participants
@mhmd-azeez @zshipko @evacchi