Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DockerComposeConfiguration : Use Map.getOrDefault instead of conditional statement #1814

Open
rohanKanojia opened this issue Aug 4, 2024 · 1 comment · May be fixed by #1815
Open

DockerComposeConfiguration : Use Map.getOrDefault instead of conditional statement #1814

rohanKanojia opened this issue Aug 4, 2024 · 1 comment · May be fixed by #1815
Assignees
@Er-Sadiq
Labels
good first issue

Comments

@rohanKanojia
Copy link
Member

Description

In DockerComposeConfiguration constructor, this code is using ternary operator to assign default values. We should use JDK's inbuilt getOrDefault method that's available on Map interface

docker-maven-plugin/src/main/java/io/fabric8/maven/docker/config/handler/compose/DockerComposeConfiguration.java

Lines 11 to 13 in 99c52cb

basedir = config.containsKey("basedir") ? config.get("basedir") : "src/main/docker";
composeFile = config.containsKey("composeFile") ? config.get("composeFile") : "docker-compose.yml";
ignoreBuild = config.containsKey("ignoreBuild") ? Boolean.parseBoolean(config.get("ignoreBuilder")) : false;

@Er-Sadiq
Copy link

Er-Sadiq commented Aug 4, 2024 •
edited
Loading

if no one is working on this issue I would like to take it up and will raise a RP soon

@rohanKanojia rohanKanojia linked a pull request Aug 5, 2024 that will close this issue
Open
Er-Sadiq added a commit to Er-Sadiq/docker-maven-plugin that referenced this issue Aug 5, 2024
@Er-Sadiq
Refactor DockerComposeConfiguration to Use getOrDefault for Default V…
a33de4f 
…alues and fixed the indentation issue:fabric8io#1814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Er-Sadiq Er-Sadiq

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

"Refactor to use getOrDefault method for default values #59" Er-Sadiq/docker-maven-plugin
2 participants
@rohanKanojia @Er-Sadiq