issues Search Results · repo:fac18/week5-EIJO-weatherAPI language:JavaScript
Filter by
37 results
(64 ms)37 results
infac18/week5-EIJO-weatherAPI (press backspace or delete to remove)ruperthnyagesoa
- Opened on Apr 10, 2023
- #70
redahaq
- Opened on Nov 29, 2019
- #52
When I use the Heroku link, the data from the API call isn t appended to the site but instead, I am redirected to
another tab that holds the JSON object.
But seeing your DOM.js file, it looks like you ...
LaLeonie
- 1
- Opened on Nov 29, 2019
- #49
It s great that you modularised your API call in a separate file. However, the point of modularisation is that you
create functions that can be reused multiple times. At the moment, the function in your ...
LaLeonie
- Opened on Nov 29, 2019
- #48
It s best to make your if-conditions in the router.js as specific as possible. This can prevent bugs if you re adding
more routes later on. For example:
- [x] else if (endpoint.includes( public )) would ...
LaLeonie
- Opened on Nov 29, 2019
- #47
I m sure you know already, but a reminder to remove any console logs you may have!
kin-au
- 1
- Opened on Nov 29, 2019
- #45
Here are a few suggestions to clean up your codebase:
- [ ] in package.json, some dev dependencies (such as tape, nyc etc.) are declared as dependencies. Best to move them
where they belong within ...
LaLeonie
- Opened on Nov 29, 2019
- #44
Ran some coverage tests! They re coming back pretty good!
Screenshot from 2019-11-29 10-40-00
The main line you want to read is for router.js since that s the one you re really testing with supertest. ...
compliment
enhancement
stretch goal
testing
freemvmt
- Opened on Nov 29, 2019
- #43
Yay, all your tests are working and you re using supertest! Great job!
Just a couple of things to add:
- It s best to put your test file(s) in a dedicated test folder
- It Would be great if you could ...
LaLeonie
- Opened on Nov 29, 2019
- #42
img width= 592 alt= Screenshot 2019-11-29 at 10 05 11 src=
https://user-images.githubusercontent.com/45558475/69865504-36fbf680-1299-11ea-98f6-f0850fe3b209.png
Well done, team! Full score on accessibility. ...
LaLeonie
- Opened on Nov 29, 2019
- #41
![Issue origami icon](/images/modules/search/issues.png)
Learn how you can use GitHub Issues to plan and track your work.
Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub IssuesProTip!
Press the /
key to activate the search input again and adjust your query.![Issue origami icon](/images/modules/search/issues.png)
Learn how you can use GitHub Issues to plan and track your work.
Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub IssuesProTip!
Restrict your search to the title by using the in:title qualifier.