-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does Ax allow attachment of trials where trails have input values outside the experiment's parameter bounds? #3269
Comments
Yes, we definitely want to support this. #3040 is relevant, which separates concepts of "modeling space" and "search space". From that PR:
So we do support this internally, but it appears the higher level API has some (potentially unnecessary; could warn instead) validation step. Could you share the full stack trace of the error? I'm having a bit of a hard time manually tracking down how this error is actually raised from your code entry point. |
Hi Max, Very glad to see I am not going crazy. I have put together this Google colab for you which you can clone and play with, follow traces etc. : The following lines will run:
While these lines will not, due to the search_space validator, because "2.0" is outside the bounds of [0.0,1.0]:
We'd like to get this sorted ASAP, shall I continue where @bletham has left off (had a quick look, so not sure how far he got), make changes and submit a merge-request? Or should we aim for some more coordination? Thanks a lot in advance! |
This addressed the internals of this on the modeling side; we essentially just need to change the user-facing API here. We're working on a new, consolidated API (preview here: https://github.com/facebook/Ax/blob/main/ax/preview/api/client.py) and the right thing to do would be to ensure things are handled properly there - cc @mpolson64 It'll be a bit until this is fully released, so one could consider updating the existing API to allow for this. Let me discuss this with some folks this week. |
Thanks for the update and context, we'll attempt a quick fix on the current API, and looking forward to what you conclude with your folks. :) |
A possible Ax data loading routine might look like this:
If the bounds set for the experiment in the Ax client are tighter than sample values in the some of the trials loaded via the routine above, an error will be raised by this validation step in search_space.py
Is this intended behaviour?
I fearing I might be abusing Ax API here, but at least theoretically, we should able to sample from posteriors generated from models with data where constraints are tighter than samples used to train the surrogate.
Thanks a lot in advance!
The text was updated successfully, but these errors were encountered: