Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Navigation Bar Size Issue with codegenNativeComponent and modalPresentationStyle: .pageSheet in React Native #47600

Open
dp221125 opened this issue Nov 14, 2024 · 0 comments
Labels
Component: Modal Needs: Triage 🔍 Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)

Comments

@dp221125
Copy link

dp221125 commented Nov 14, 2024

Description

In a React Native environment, I'm using codegenNativeComponent to display a native screen. On this native screen, when I present a new screen with modalPresentationStyle set to .pageSheet, the navigation bar size becomes abnormal. Although this might appear to be an issue with the native side because I’m using native screens, I don’t experience this problem when presenting a modal with .pageSheet without React Native.

Steps to reproduce

  1. Clone the repository: RNPlayground.
  2. Navigate to the RNPlayground/react-native-playground folder.
  3. Run yarn install.
  4. Return to the root directory and run pod install (or bundle install followed by bundle exec pod install if using Bundler).
  5. Open RNPlayground.xcworkspace and build the project for an iPhone targeting iOS 16 or 17.
  6. When the app launches, tap the "Show Detail" button displayed on the screen.

React Native Version

0.76.1

Affected Platforms

Runtime - iOS

Areas

Other (please specify)

Output of npx react-native info

System:
  OS: macOS 14.7
  CPU: (10) arm64 Apple M1 Pro
  Memory: 227.33 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.17.0
    path: ~/.asdf/installs/nodejs/20.17.0/bin/node
  Yarn:
    version: 4.5.0
    path: ~/.asdf/installs/nodejs/20.17.0/bin/yarn
  npm:
    version: 10.8.2
    path: ~/.asdf/plugins/nodejs/shims/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.16.2
    path: /Users/seokho/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 24.0
      - iOS 18.0
      - macOS 15.0
      - tvOS 18.0
      - visionOS 2.0
      - watchOS 11.0
  Android SDK: Not Found
IDEs:
  Android Studio: 2022.2 AI-222.4459.24.2221.10121639
  Xcode:
    version: 16.0/16A242
    path: /usr/bin/xcodebuild
Languages:
  Java: Not Found
  Ruby:
    version: 3.1.3
    path: /Users/seokho/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli":
    installed: 15.0.0
    wanted: 15.0.0
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.76.1
    wanted: 0.76.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: true
  newArchEnabled: true

Stacktrace or Logs

Not a crash, not a failure, just a UI bug.

Reproducer

https://github.com/dp221125/RNPlayground

Screenshots and Videos

React Native

Simulator.Screen.Recording.-.iPhone.13.mini.-.2024-11-14.at.11.35.55.mp4

iOS Native (not using React Native)

Simulator.Screen.Recording.-.iPhone.13.mini.-.2024-11-14.at.11.34.42.mp4

ScreenShot

image
@dp221125 dp221125 added Needs: Triage 🔍 Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) labels Nov 14, 2024
@dp221125 dp221125 changed the title Navigation Bar Size Issue with codegenNativeComponent and modalPresentationStyle: .pageSheet in React Native [iOS] Navigation Bar Size Issue with codegenNativeComponent and modalPresentationStyle: .pageSheet in React Native Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Modal Needs: Triage 🔍 Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)
Projects
None yet
Development

No branches or pull requests

2 participants