Enable ban_spread_key_props in xplat/js #47636
Closed
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64427942 |
jackpope
pushed a commit
to jackpope/react-native
that referenced
this pull request
Nov 15, 2024
Summary: We're cleaning up key spreads across WWW/Fbsource. Flow's `ban_spread_key_props` option allows us to fix existing spreads and prevent new ones from being added in code covered by Flow. Here we fix spreads within xplat/js. Also based on a unit test keeping config in sync, I've added the option to metro and RN OSS as well. Reviewed By: SamChou19815 Differential Revision: D64427942
jackpope
force-pushed
the
export-D64427942
branch
from
3043a07
to
7fc3c28
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64427942 |
Summary: We're cleaning up key spreads across WWW/Fbsource. Flow's `ban_spread_key_props` option allows us to fix existing spreads and prevent new ones from being added in code covered by Flow. Here we fix spreads within xplat/js. Also based on a unit test keeping config in sync, I've added the option to metro and RN OSS as well. Reviewed By: SamChou19815 Differential Revision: D64427942
jackpope
force-pushed
the
export-D64427942
branch
from
7fc3c28
to
ebe5f0a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64427942 |
|
This pull request has been merged in 55a4d10. |
|
This pull request was successfully merged by Jack Pope in 55a4d10 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We're cleaning up key spreads across WWW/Fbsource. Flow's
ban_spread_key_propsoption allows us to fix existing spreads and prevent new ones from being added in code covered by Flow.Here we fix spreads within xplat/js.
Also based on a unit test keeping config in sync, I've added the option to metro and RN OSS as well.
Reviewed By: SamChou19815
Differential Revision: D64427942