Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

New nightly #1189

Merged
merged 11 commits into from
Nov 18, 2022
Merged

New nightly #1189

merged 11 commits into from
Nov 18, 2022

Conversation

hermanventer
Copy link
Contributor

Description

Update the tool chain specification to the latest nightly and make it compile.

As yet, this is not ready for merging because there are some test regressions that are taking a lot time to debug.

It may work well enough for experiment use.

Fixes #1188

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

./validate.sh

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 30, 2022
@hermanventer hermanventer marked this pull request as draft October 30, 2022 01:20
@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #1189 (5ca2f1e) into main (2735171) will decrease coverage by 0%.
The diff coverage is 63%.

@@          Coverage Diff           @@
##            main   #1189    +/-   ##
======================================
- Coverage     77%     76%    -1%     
======================================
  Files         23      23            
  Lines      16278   16460   +182     
======================================
+ Hits       12603   12625    +22     
- Misses      3675    3835   +160
Impacted Files Coverage Δ
checker/src/z3_solver.rs 48% <0%> (-1%) ⬇️
checker/src/crate_visitor.rs 69% <12%> (-5%) ⬇️
checker/src/block_visitor.rs 75% <64%> (-5%) ⬇️
checker/src/type_visitor.rs 75% <83%> (-1%) ⬇️
checker/src/expected_errors.rs 81% <85%> (-1%) ⬇️
checker/src/environment.rs 87% <100%> (-1%) ⬇️
checker/src/utils.rs 81% <100%> (ø)
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arnaudvenet arnaudvenet marked this pull request as ready for review November 18, 2022 06:35
@arnaudvenet arnaudvenet merged commit 2368aac into main Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request of a nightly Rust toolchain update
3 participants
@hermanventer @facebook-github-bot @arnaudvenet