Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static route fails to serve byterange on Meinheld #1992

Open
vytas7 opened this issue Nov 13, 2021 · 1 comment
Open

Static route fails to serve byterange on Meinheld #1992

vytas7 opened this issue Nov 13, 2021 · 1 comment

Comments

@vytas7
Copy link
Member

vytas7 commented Nov 13, 2021

Apparently, setting resp.stream to a file-like object without a file descriptor (i.e., without a .fileno() method, such as a pure Python wrapper implementing .read()), fails in Meinheld with a TypeError.

I am of the opinion that Meinheld's behaviour is in direct violation of PEP 3333 on the matter, and filed this as a bug: mopemope/meinheld#130.
However, since Meinheld is one of the fastest ways to run Falcon, we probably need to decide whether we want to patch this on our side, document as a known limitation, or take another action (please suggest).

@CaselIT
Copy link
Member

CaselIT commented Nov 13, 2021

we probably need to decide whether we want to patch this on our side, document as a known limitation, or take another action (please suggest).

Personally I think we could just document this case. As an alternative we could provide a different implementation but I think it would be better to make it configurable by the user and not activating it automatically when running under a wsgi server

@vytas7 vytas7 added this to the Version 3.2 milestone Dec 20, 2021
@vytas7 vytas7 modified the milestones: Version 4.1, Version 4.x Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants