-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAI-14070/FAI-14071: Add use_board_ownership flag to Jira Source #1908
base: main
Are you sure you want to change the base?
Conversation
…haviour is true (as it was working as today) When flag is set to false: - Board list is populated with project uids - Project-board relation created 1-1 with project uid. - The board_issues stream is removed from list. - Task-board relationship is written on faros_issues stream using project uid.
Hmmm, did we say we wanna re-add this? We had previously explicitly. Also we that other dummy board |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are sprint report boards being handled, are they all gonna be phantoms. Can we add some tests to validate these mappings
destinations/airbyte-faros-destination/src/converters/jira/faros_issues.ts
Show resolved
Hide resolved
Didn't finish that implementation yet. Trying to think the best approach. The impl. on feeds leaves all boards as phantoms, but then they get linked to the project dummy board on the reports. Maybe we could link them directly to the project board on the graph... |
…ecated. Refactor logic and other fixes.
|
The issue here is that we are using board slices for sprint and sprint reports, to query sprints by board id. But here the board slices will contain the project key... So I'm not sure if we should query sprints for all project's boards all together for this case and if that would be performant also. |
Description
We are adding use_board_ownership flag, like the one we had on the feed, to be able to keep using it with 1 board per project.
Default behavior is use_board_ownership:true, as it was working as today.
When flag is set to false:
TODO
Type of change
Related issues
Migration notes
Extra info