Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark workflow #89

Closed
3 of 7 tasks
Uzlopak opened this issue Jul 28, 2023 · 5 comments · Fixed by #90
Closed
3 of 7 tasks

Benchmark workflow #89

Uzlopak opened this issue Jul 28, 2023 · 5 comments · Fixed by #90

Comments

@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 28, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

We should have a nice benchmark workflow for use in different repos.

While writing the benchmark workflow of fsj, i saw some issues, which should be tackled:

  • the pr comment action is using node 12 and results in warnings. I am pretty sure we can use octokit/request-action instead
  • we should use the new way to handle outputs, see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ . I tried to use it, but there a formatting issues which dont work with the new way of outputting information.
  • we should think of a way to handle a matrix strategy for the node version. Input variables can not be array. So we should check if you are just pass a comma separated list, where we slab brackets around and the use the json parse method of the github runner. This we could use for the other workflows here in this repo too. But for fsj, i dont need benchmarks from node14 to node 20. I just need one, and thats the lts.
  • we need to investigate a nice way to create the pull request body.
  • we should use the default_branch information from the event instead of hardcoding 'master' or 'main'. Maybe use an input variable, where default is the default_branch?

Motivation

No response

Example

No response

@Uzlopak Uzlopak assigned RafaelGSS and Fdawgs and unassigned RafaelGSS and Fdawgs Jul 28, 2023
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jul 28, 2023

@Fdawgs
@RafaelGSS

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 2, 2023

Multiline works with this: github/docs#21529

Tested it

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 3, 2023

Removing a label

  remove-label:
    if: "always()"
    needs: 
      - benchmark
      - output-benchmark
    runs-on: ubuntu-latest
    steps:
      - name: Remove benchmark label
        uses: octokit/[email protected]
        id: remove-label
        with:
          route: DELETE /repos/{repo}/issues/{issue_number}/labels/{name}
          repo: ${{ github.event.pull_request.head.repo.full_name }}
          issue_number: ${{ github.event.pull_request.number }}
          name: benchmark
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 4, 2023

Ok, proposed a solution

@github-actions
Copy link

🎉 This issue has been resolved in version 3.9.0 🎉

The release is available on:

Your optic bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants