Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclutter log output #335

Open
jameysharp opened this issue Dec 9, 2023 · 0 comments
Open

Unclutter log output #335

jameysharp opened this issue Dec 9, 2023 · 0 comments
Labels
feature-ux Concerning ergonomics and ease-of-use

Comments

@jameysharp
Copy link
Contributor

Viceroy produces quite a bit of output per request, and it's not clear to me which parts are important. It'd be nice to have a conversation about exactly what should get printed.

At the default log level, with the guest profiler enabled, I get output like this:

2023-12-07T19:34:42.284284Z  INFO Listening on http://127.0.0.1:7676
2023-12-07T19:34:50.930338Z  INFO request{id=0}: handling request GET http://127.0.0.1:7676/?n=40
2023-12-07T19:34:51.391808Z  INFO request{id=0}:
Profile written to: guest-profiles/1701977690-0.json
View this profile at https://profiler.firefox.com/.
2023-12-07T19:34:51.391825Z  INFO request{id=0}: request completed using 1.4 MB of WebAssembly heap
2023-12-07T19:34:51.391829Z  INFO request{id=0}: request completed in 461ms

If issues #77 and #78 were implemented they would add two more lines like the last two. The request statistics might be better all on a single line, perhaps?

When the user has requested guest profiling they probably care most about how to view the profile, so more thought on how to make that stand out would be great.

I'm not sure it's useful to include the date, or microsecond-resolution time, on each line. Also, maybe it would be more useful to display local time rather than UTC.

I don't really know what this should look like, but I hope these comments can be a good starting point for discussion.

@jameysharp jameysharp added the feature-ux Concerning ergonomics and ease-of-use label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-ux Concerning ergonomics and ease-of-use
Projects
None yet
Development

No branches or pull requests

1 participant