Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add foreman to docker config described in the README #56

Open
3 tasks done
fbuys opened this issue Dec 8, 2021 · 4 comments
Open
3 tasks done

[BUG] Add foreman to docker config described in the README #56

fbuys opened this issue Dec 8, 2021 · 4 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@fbuys
Copy link
Contributor

fbuys commented Dec 8, 2021

IMPORTANT: please make sure you ask yourself all intro questions and fill all sections of the template.

Before we start...:

  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed
  • I'm reporting the issue to the correct repository (for multi-repository projects)

Expected behavior:

Information about how to run dotenv_validator when you use foreman.

Actual behavior:

No informatino about how use dotenv_validator when you use foreman.

Context and environment:

We can update this part of the README: https://github.com/fastruby/dotenv_validator#if-you-use-docker-compose-read-this
to explain that it applies to foreman too.

For more context refer to this issue: fastruby/rails-template#23

I will abide by the code of conduct

@fbuys fbuys added bug Something isn't working documentation Improvements or additions to documentation labels Dec 8, 2021
@aisayo aisayo self-assigned this Aug 10, 2022
@aisayo
Copy link

aisayo commented Aug 10, 2022

@fbuys @arielj I realized there is a discussion on whether it is necessary to add this documentation to the README on issue #23, want to confirm if we still want to move forward with this?

@arielj
Copy link
Contributor

arielj commented Aug 31, 2022

@aisayo this foreman issue is unrelated to the dependency on the dotenv gem, we have to still explain in the readme that foreman (like docker), read the .env file differently than dotenv

@etagwerker
Copy link
Member

@arielj The table in the README no longer points to a section of the README in the dotenv project. I assume that README's sections changed and maybe it should now point to: https://github.com/bkeepers/dotenv?tab=readme-ov-file#customizing-rails

@etagwerker
Copy link
Member

I think it would be useful to add something to the README that points to this issue: ddollar/foreman#702 (comment)

There is a workaround for people who want to use both dotenv and foreman

@etagwerker etagwerker added the good first issue Good for newcomers label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants