Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magic serverRequire #10

Open
dereke opened this issue Mar 28, 2017 · 0 comments
Open

magic serverRequire #10

dereke opened this issue Mar 28, 2017 · 0 comments

Comments

@dereke
Copy link
Member

dereke commented Mar 28, 2017

server.run(function() {
  serverRequire('fs')
})

is all a bit too magic it also trips up linters because they don't know serverRequire exists. Maybe serverRequire should become this.serverRequire('fs') or become a parameter passed into the run callback.

Anyway some way of deglobalising it would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant