Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make more uses of Jinja templates #214

Open
darknao opened this issue Nov 3, 2021 · 3 comments
Open

Make more uses of Jinja templates #214

darknao opened this issue Nov 3, 2021 · 3 comments
Assignees
@subhangi2731
Labels
fragment A functional rewrite of the project frontend Frontend development good first issue Good for newcomers hacktoberfest Contribute here to get a free tee T: improvement Improves on something that already exists

Comments

@darknao
Copy link
Collaborator

darknao commented Nov 3, 2021

We only have 3 html templates for now, but we already have parts of the same code on all of them.

Use the power of templating to refactor those pages and eliminate code duplicates like footer & header.
See https://jinja.palletsprojects.com/en/3.0.x/templates/
@darknao darknao added the good first issue Good for newcomers label Nov 3, 2021
@subhangi2731
Copy link
Contributor

@darknao can I work on this?

@gridhead
Copy link
Member

gridhead commented Nov 4, 2021

@subhangi2731, there you go.

@gridhead gridhead added fragment A functional rewrite of the project frontend Frontend development T: improvement Improves on something that already exists labels Nov 4, 2021
@subhangi2731
Copy link
Contributor

@t0xic0der @darknao As I've observed, this needs topbar & footers across all the pages to be consistent with each other, which isn't the case currently. So, this issue can be worked only on merging these two short MRs: #207 #210

@gridhead gridhead mentioned this issue Aug 11, 2022
Merged
@gridhead gridhead added the hacktoberfest Contribute here to get a free tee label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@subhangi2731 subhangi2731

Labels
fragment A functional rewrite of the project frontend Frontend development good first issue Good for newcomers hacktoberfest Contribute here to get a free tee T: improvement Improves on something that already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@darknao @gridhead @subhangi2731