Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this still a thing' ? I mean were on DirectX 12 now.. #156

Open
WilsonBradley opened this issue Apr 5, 2023 · 11 comments
Open

Is this still a thing' ? I mean were on DirectX 12 now.. #156

WilsonBradley opened this issue Apr 5, 2023 · 11 comments

Comments

@WilsonBradley
Copy link

Would be great to get some TLC / love for new revision..

@WilsonBradley
Copy link
Author

New Nvidia drivers/settings And RTX 40' series

@fholger
Copy link
Owner

fholger commented Apr 5, 2023

Games that are new enough to use DX12 should be new enough to use OpenXR. In which case you should be looking at the OpenXR toolkit and not this.

@ThickCloud
Copy link

In my limited experience, this solution provides more flexibility, a superior capability set, simpler implementation and, most importantly, better performance that openxr...

I switched back from OpenXR last summer/fall.

Brilliant work!

@oskansavli
Copy link

I agree that SteamVR + vrperfkit is faster than OpenXR with the integrated FFR tool. Tested multiple times with RTX4090 and RTX3070 mobile. OpenXR uses a bit less VRAM though.

I hope this is updated for DX12.

@Zod1234
Copy link

Zod1234 commented Sep 8, 2023

does this have all the features of fsr2? I wanted to see how dynamic resolution scaling performed. just a side note, the predecessor of vrperfkit still has uses. I recently started playing valheim which is a vrmod that uses the same DLL so to get any resolution scaling I was your prior work existed. it seems this would still potentially be an issue for other vr mods.

@fholger
Copy link
Owner

fholger commented Sep 8, 2023

No, this is FSR1, not 2. And it never will be 2 - you can't integrate FSR2 into games in a generic way as it requires closer engine integration.

@theguycanfly
Copy link

theguycanfly commented Sep 8, 2023 via email

@fholger
Copy link
Owner

fholger commented Sep 8, 2023

Driver features do not apply to VR.

@theguycanfly
Copy link

theguycanfly commented Sep 8, 2023 via email

@Zod1234
Copy link

Zod1234 commented Sep 8, 2023

No, this is FSR1, not 2. And it never will be 2 - you can't integrate FSR2 into games in a generic way as it requires closer engine integration.

you're right of course. did some more reading and makes sense because it's a temporal scaler. but did more reading, amd also has something called Radeon boost which is dynamic resolution scaling. I feel dynamic resolution scaling could be more impactful because you can be more aggressive to hit your fps target and when the action slows down, it'll scale up. I read this is also only per game currently, but I couldn't find out if there is a technical barrier that would prevent this from being applied to any game. one benefit of doing it in game is avoiding doing it on the HUD, but besides that, if there's no temporal info needed, couldn't this in theory work in any game? Is it in their open source release?

I've never tried dynamic res in a game but curious how well it would work. not many pc games have done this prior to Radeon boost. One that did is doom 2016, but strangely it was disabled on PC and only used in consoles. Here's a vid of it being unlocked on PC and it looks pretty impressive. this looks like intelligent scaling trying to reach an fps target rather than the static scaling we use today.

Did you have any thoughts on openvr_fsr still having use? I know the future is openxr, but the transition is taking a long time. And again with mods helping vr a fair bit, openvr_fsr is the only option when mods are used. still works fine as is, just thinking if vrperfkit did get new features that potentially openvr_perf could benefit from. Although it sounds like both are considered feature complete at this point. read you paused to work on hl2. just finished that recently. absolutely awesome in vr! thx for all your contributions.

https://www.youtube.com/watch?v=GS_PhWP9YQI&t=746s

@Zod1234
Copy link

Zod1234 commented Sep 29, 2023

Games that are new enough to use DX12 should be new enough to use OpenXR. In which case you should be looking at the OpenXR toolkit and not this.

losing out on steamvr bindings is tough. and I much prefer this method of deployment with a custom cfg tailored to the game VS an onscreen display. ideally we would all be using openxr, but the reality is what's keeping pcvr alive is mods and very few are using openxr. and those that do seem to have trouble with openxr toolkit. just tried dx12 re2 vr mod set to openxr with the toolkit and it locked my system.

I get your sentiment but I think many would benefit from dx12 support in vrperfkit. i know I would.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants