-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo deprecated in favor of multiview-reconstruction? #144
Comments
@NicoKiaru Can you be more specific about what "weird bugs"? How to reproduce? @StephanPreibisch On which of update site(s) does this project belong? There are three targets:
If I don't hear from you, I'll leave this project on Java-8, but remove it from Java-21. See also https://forum.image.sc/t/housecleaning-fiji-for-the-java-21-update/107452 |
Yes, sure, sorry, I experienced it and filed a bug in order not to forget about it. Thought I was going to add more info and got into something else. I obtain a NPE when:
here's the stack trace:
/C:/Fiji.app/plugins/SPIM_Registration-5.0.25.jar /C:/Fiji.app/plugins/multiview_reconstruction-4.3.6.jar What I understand now is that the apply transformation plugin was moved from SPIM_Registration to multiview_reconstruction, thus from the Java 8 update site to the BigStitcher update site. I see that the BigStitcher update site now shadows SPIM_Registration with a stub file named SPIM_Registration-0.0.1.jar that contains (almost) nothing. For some reasons I ended up with a SPIM_Registration jar which was not a STUB and a new multiview reconstruction jar which also contained the Apply Transformation plugin. Maybe that's a mistake on my side and it won't happen somewhere else. But still from what I understand this means that this repo should be abandoned / archived. |
Note: since this repo is most likely phased out, the documentation will need to be updated, and probably removed: https://imagej.net/plugins/spim-registration/ |
I would favor instead trying to fix this incompatibility. Otherwise, old scripts and macros that use this functionality would break. I'm in favor of clearing marking obsolete documentation, but probably not deleting it unless the maintenance burden becomes substantial. I'll try to investigate as part of (or very shortly after) the impending Java 21 rollout; this issue is listed on the Fiji Fit project board. |
Ok, I can't reproduce since the pom scijava 40 update. I think I have done something wrong. I close it for now. Please re-open if you think there's something to dig |
Hi, yes, let's remove it ... but other projects might depend on it. Should we try again moving BigStitcher to the Java8 site @ctrueden? Should be easier now I guess ... |
I think this repo needs to be removed from the Java-8 update site. It has conflicts with multiview-reconstruction. This leads to weird bugs.
The text was updated successfully, but these errors were encountered: