ChainIndexer: GetMsgInfo should return ErrNotFound when not found

[rvagg]

2024-11-06T21:13:14.735+1100    WARN    statemgr        stmgr/searchwait.go:175 error searching message index: error looking up message in index: sql: no rows in result set

Lots of this kind of thing in the logs, but it shouldn't be logged:

lotus/chain/stmgr/searchwait.go

Lines 171 to 176 in 8865a9d

	case errors.Is(err, index.ErrNotFound):
	// ok for the index to have incomplete data
	default:
	log.Warnf("error searching message index: %s", err)
	}

GetMsgInfo should return an ErrNotFound when there are no rows, here:

lotus/chain/index/read.go

Lines 51 to 54 in 8865a9d

	if err := si.queryMsgInfo(ctx, messageCid, &tipsetKeyCidBytes, &height); err != nil {
	return nil, err
	}

Needs tests as well.