Bug: Run with PowerShell doesn't use scripts location as working directory

[Jack251970]

Description

When I use system Explorer to run this powershell file with Run with Powershell Context Menu Item, it works well.

But when I use Files to run powershell file with Run with Powershell Context Menu Item, I encounter this issue.

These are the contents of my ps1 file and I just want to run one dotnet run task.

dotnet run --project build/Build.csproj
exit $LASTEXITCODE;

Related file tree is like that:

• build.ps1
  • build/Build,csproj

Steps To Reproduce

1. Create one VS project.
2. Create ps1 file for it.
3. Run this ps1 file.

Files Version

3.9.1.0

Windows Version

10.0.26100.3194

User ID

a2edf6d2-76d7-4004-bceb-5cd7ffa27d13

Log File

debug.log

[Josh65-2201]

Thanks for the report, can you screenshot the full PowerShell window

[yaira2]

Are you using the action on the toolbar, or the shell extension in the context menu?

[Jack251970]

Thanks for the report, can you screenshot the full PowerShell window

Sure! This is the full screenshot.

[Jack251970]

Are you using the action on the toolbar, or the shell extension in the context menu?

@yaira2 I find that neither of them can work. They both give me the issue as above.

[Josh65-2201]

Are you able to add the working directory path to the script and send the output

[Jack251970]

@Josh65-2201 Hello, thanks for you reply! I think I have found the reason. If I want to execute ps1 file in Files, I need to add one more line: Set-Location -Path $PSScriptRoot to set working directory to the script's location.

However, I am very curious that why files set C:\WINDOWS\System32 by default. (For Explorer, you do not need to add this.)

[Josh65-2201]

It's not suppose to, you might be able to create a shortcut to the script and leave the start in target in properties blank to get the correct path.

[Jack251970]

It's not suppose to, you might be able to create a shortcut to the script and leave the start in target in properties blank to get the correct path.

@Josh65-2201 Sorry I know really little about this. Could you provide me more details?

And if you do not think this is a issue, feel free to close it.

[Josh65-2201]

It is an issue, what I suggest is a workaround until it fixed. You can right click the script file > Create shortcut > Right click the shortcut > Open properties > Go to Shortcut > Check that Start in text box is empty > Run the shortcut and see if it get the correct path

[ferrariofilippo]

We might add an optional workingDirectory param to the function declaration and then assign it to Process.StartInfo.WorkingDirectory

Files/src/Files.App/Helpers/Win32/Win32Helper.Storage.cs

Lines 869 to 874 in 005ebd4

	private static Process CreatePowershellProcess(string command, PowerShellExecutionOptions options)
	{
	Process process = new();
	process.StartInfo.FileName = "powershell.exe";

[yaira2]

Modfying CreatePowershellProcess can cause unexpected behavior elsewhere, but perhaps we can create a separate method that uses the working dirctory.

[ferrariofilippo]

Modfying CreatePowershellProcess can cause unexpected behavior elsewhere, but perhaps we can create a separate method that uses the working dirctory.

Something like this shouldn't affect existing code

                private static Process CreatePowershellProcess(string command, PowerShellExecutionOptions options, string? wd = null)
                {
                    ...
                    if (wd is not null)
                        process.StartInfo.WorkingDirectory = wd;

[yaira2]

Let's try it out