Skip to content
This repository has been archived by the owner on Jan 29, 2022. It is now read-only.

Color / Formatting code parsing #22

Open
jleclanche opened this issue Jan 6, 2016 · 4 comments
Open

Color / Formatting code parsing #22

jleclanche opened this issue Jan 6, 2016 · 4 comments

Comments

@jleclanche
Copy link
Contributor

The bot fails to parse formatting codes:

GitHub [�13python-unitypack�] �15jleclanche� pushed �1� new commit to �06master�: �02�https://github.com/HearthSim/python-unitypack/commit/b29ac66f2fb2c825e29ceea63591a7a0441fd3e6�
GitHub �13python-unitypack�/�06master� �14b29ac66� �15Jerome Leclanche�: Implement pointer struct parsing
@finnp
Copy link
Owner

finnp commented Jan 6, 2016

Since gitter does not seem to support colors, I guess we should just strip those characters (https://github.com/chalk/strip-ansi)

@jleclanche
Copy link
Contributor Author

Sure. You might want to support the bold/italics/underline characters though.

@finnp
Copy link
Owner

finnp commented Jan 6, 2016

Good point!

@gazpachoking
Copy link

I just pasted the stripping code from https://www.npmjs.com/package/irc-colors into my instance. Maybe just use something already written like that for colors?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants