Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vote_account_path to vote_account_name_or_path #4242

Open
geldmon opened this issue Feb 17, 2025 · 0 comments
Open

Rename vote_account_path to vote_account_name_or_path #4242

geldmon opened this issue Feb 17, 2025 · 0 comments

Comments

@geldmon
Copy link

geldmon commented Feb 17, 2025

#3917 removed the check for vote key path check so now it's possible to pass a pubkey.
Improving semantics on the vote_account_path option to better reflect this change would be very helpful for NOs.

 # This option is passed to the Agave client with the
    # `--vote-account` argument.
    vote_account_path = ""

Suggesting to rename to vote_account_name_or_path or add a completely new option vote_account_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant