You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove FD_BORROWED_ACCOUNT_TRY_BORROW_IDX macro and add those borrow checks into the account borrowing APIs in fd_exec_instr_ctx.h and fd_exec_txn_ctx.h.
The text was updated successfully, but these errors were encountered:
Match Agave borrowed account semantics where possible. These changes include the following:
fd_borrowed_account_t
, which is a wrapper aroundfd_txn_acct
that includes the instruction context, the index of the instruction / transaction account... matching agave as close as possible. Link to agave: https://github.com/firedancer-io/agave/blob/943bd6bbafc85c729eb276dcc0564f5fbcca9814/sdk/src/transaction_context.rs#L703fd_account.h
to eitherfd_borrowed_account.h
orfd_exec_instr_ctx.h
, depending on whether they act upon the borrowed account or upon the instruction context. This will more closely match agave as well, for example, this link shows theset_lamports
function in theBorrowedAccount
class: https://github.com/firedancer-io/agave/blob/943bd6bbafc85c729eb276dcc0564f5fbcca9814/sdk/src/transaction_context.rs#L773FD_BORROWED_ACCOUNT_TRY_BORROW_IDX
macro and add those borrow checks into the account borrowing APIs infd_exec_instr_ctx.h
andfd_exec_txn_ctx.h
.The text was updated successfully, but these errors were encountered: