Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct BCs with wrappers (including mixed options) #514

Open
ta440 opened this issue Jul 22, 2024 · 0 comments
Open

Correct BCs with wrappers (including mixed options) #514

ta440 opened this issue Jul 22, 2024 · 0 comments
Labels
bug Pull requests or issues to relating to something not working enhancement Pull requests or issues relating to adding a new capability question Issues that involve a question that needs answering

Comments

@ta440
Copy link
Collaborator

ta440 commented Jul 22, 2024

Currently, if any wrappers are used, the boundary conditions default to Dirichlet conditions on all fields, which surely wouldn't be correct for all cases?

In the time_discretisation.py file:
elif self.wrapper is not None: # Transfer boundary conditions onto test function space self.bcs = [DirichletBC(self.fs, bc.function_arg, bc.sub_domain) for bc in bcs]

This arose as an error when trying to use the mixed_options wrapper when simultaneously transporting multiple fields with SIQN. When doing so, we use the full mixed space, so applying the individual Dirichlet BCs is not compatible with this.

@tommbendall tommbendall added bug Pull requests or issues to relating to something not working enhancement Pull requests or issues relating to adding a new capability question Issues that involve a question that needs answering labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Pull requests or issues to relating to something not working enhancement Pull requests or issues relating to adding a new capability question Issues that involve a question that needs answering
Projects
None yet
Development

No branches or pull requests

2 participants