Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove complex-proxy once it's available somewhere common #526

Open
JHopeCollins opened this issue Jul 24, 2024 · 0 comments
Open

Remove complex-proxy once it's available somewhere common #526

JHopeCollins opened this issue Jul 24, 2024 · 0 comments
Assignees
Labels
external issue Pull requests or issues relating to an external issue

Comments

@JHopeCollins
Copy link
Collaborator

The complex_proxy module from was used to refactor the REXI code in #520. To avoid Gusto depending on asQ the whole module and tests were copied over from asQ. This duplicates code and means that any updates to the module need to be manually added in both repositories.

We're going to look at making complex_proxy available standalone without needing all of asQ (firedrakeproject/asQ#199). Once this is done Gusto should use this version and remove the local copy.

@JHopeCollins JHopeCollins added the external issue Pull requests or issues relating to an external issue label Jul 24, 2024
@JHopeCollins JHopeCollins self-assigned this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external issue Pull requests or issues relating to an external issue
Projects
None yet
Development

No branches or pull requests

1 participant