Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Allow configuring fission namespace #22

Open
soamvasani opened this issue Aug 10, 2017 · 2 comments
Open

Allow configuring fission namespace #22

soamvasani opened this issue Aug 10, 2017 · 2 comments

Comments

@soamvasani
Copy link
Member

fission-ui hardcodes the controller namespace as "fission". However with the fission helm chart, the namespace could be anything that the user sets; when it's not "fission", fission-ui nginx crashes with:

2017/08/10 00:35:15 [emerg] 1#1: host not found in upstream "controller.fission" in /etc/nginx/conf.d/default.conf:36
nginx: [emerg] host not found in upstream "controller.fission" in /etc/nginx/conf.d/default.conf:36

This seems to be the place it's hardcoded:
https://github.com/fission/fission-ui/blob/master/docker/fission-ui.conf#L36

Some sort of environment variable would do the trick. Then we could set it in the deployment yaml.

yqf3139 added a commit that referenced this issue Aug 10, 2017
@yqf3139
Copy link
Contributor

yqf3139 commented Aug 10, 2017

@soamvasani
I just make the change. And I change the tag to latest.
I will have a look at fission helm chart config for ui later.

@yqf3139
Copy link
Contributor

yqf3139 commented Aug 10, 2017

And there is an other solution to use just controller as upstream, but for flexibility, in current solution ui can deploy in another namespace.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants