Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixie deploy fails on Windows in 0.2.24 #187

Open
petersalas opened this issue Jun 5, 2023 · 1 comment
Open

fixie deploy fails on Windows in 0.2.24 #187

petersalas opened this issue Jun 5, 2023 · 1 comment
Assignees
@petersalas

Comments

@petersalas
Copy link
Contributor

gql internally uses isinstance(x, io.IOBase) to see if a value is a file-like. On macOS this is True for tempfile.TemporaryFile but on Windows this is False, which breaks the CLI.
@petersalas petersalas self-assigned this Jun 5, 2023
@petersalas
Copy link
Contributor Author

Downgrading to 0.2.23 is no longer an option because the service now requires 1.0+. @mdwelsh can you take a look? We might just need to switch to NamedTemporaryFile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petersalas petersalas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petersalas