Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip as button started loading even after the ad playback is paused #23

Open
vinoddirishala opened this issue Nov 26, 2020 · 3 comments

Comments

@vinoddirishala
Copy link

vinoddirishala commented Nov 26, 2020

The skip ad button is completing it's offset even the ad playback is paused. Are there any callbacks to handle this ?

@vinoddirishala vinoddirishala changed the title <!-- Error while uploading Screenshot_2020-11-26-20-21-55-559_com.vinod.exoplayer.jpg --> Skip as button started loading even after the ad playback is paused Nov 26, 2020
@vinoddirishala
Copy link
Author

skipAD madman

@anirudhramanan
Copy link
Collaborator

anirudhramanan commented Nov 30, 2020

No, the DefaultAdRenderer runs a separate count down timer for skip ads.

This is part of our backlog, will be picked up soon. The ideal case is where the AdManager constantly gives state / progress callbacks to the AdRenderer, and the AdRenderer handles such cases.

@anirudhramanan
Copy link
Collaborator

The fix has been merged to develop. You can use jitpack for now to create a snapshot from develop to use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants