Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Remove headless-ui; replace with radixui #3759

Open
markphelps opened this issue Dec 27, 2024 · 4 comments
Open

V2: Remove headless-ui; replace with radixui #3759

markphelps opened this issue Dec 27, 2024 · 4 comments
Labels
help wanted Halp ui v2 For consideration for v2 of Flipt

Comments

@markphelps
Copy link
Collaborator

markphelps commented Dec 27, 2024

Headless UI has moved on to v2 and v1 is deprecated

@erka has already taken some of the steps to move some components over to RadixUI here: #3634

We should continue the work to move off of headlessui where possible (where there is a matching component in radixUI

I'd like to propose the following:

  1. We do this over several PRs, component by component
  2. When updating, we move all shared components to the root ui/components folder (ie: everything in ui/components/ui + ui/components/forms, etc all go into the root ui/components. I think this will help with discoverability, meaning if someone new comes in they will more easily find these existing components instead of trying to implement new ones
  3. We ensure the visual styles of the new radix based components match existing components as closely as possible

FLI-1388

@markphelps markphelps changed the title Remove headless-ui; replace with radixui [FLI-1388] Remove headless-ui; replace with radixui Dec 27, 2024
@kartik-raj7
Copy link

Hey can i work on this issue

@markphelps
Copy link
Collaborator Author

@kartik-raj7 ty! Assigned to you

@markphelps markphelps removed the lg label Jan 18, 2025
@markphelps markphelps changed the title [FLI-1388] Remove headless-ui; replace with radixui V2: Remove headless-ui; replace with radixui Feb 12, 2025
@markphelps
Copy link
Collaborator Author

Moving this to be v2 only (v2 branch)

@markphelps markphelps added v2 For consideration for v2 of Flipt and removed good first issue labels Feb 12, 2025
@markphelps
Copy link
Collaborator Author

Remaining headless ui references:

src/components/variants/VariantForm.tsx
1:import { Dialog } from '@headlessui/react';

src/components/forms/Listbox.tsx
1:import { Listbox as L, Transition } from '@headlessui/react';

src/components/panels/DeletePanel.tsx
1:import { Dialog } from '@headlessui/react';

src/components/panels/CopyToNamespacePanel.tsx
1:import { Dialog } from '@headlessui/react';

src/components/Combobox.tsx
1:import { Combobox as C } from '@headlessui/react';

src/components/namespaces/NamespaceForm.tsx
1:import { Dialog } from '@headlessui/react';

src/components/rules/RuleForm.tsx
1:import { Dialog } from '@headlessui/react';

src/components/Sidebar.tsx
1:import { Dialog, Transition } from '@headlessui/react';

src/components/command/CommandDialog.tsx
1:import { Dialog } from '@headlessui/react';

src/components/Slideover.tsx
1:import { Dialog, Transition } from '@headlessui/react';

src/components/Modal.tsx
1:import { Dialog, Transition } from '@headlessui/react';

src/components/rollouts/EditRolloutForm.tsx
1:import { Dialog } from '@headlessui/react';

src/components/rollouts/RolloutForm.tsx
1:import { Dialog } from '@headlessui/react';

src/components/notifications/SuccessNotification.tsx
1:import { Transition } from '@headlessui/react';

src/components/notifications/ErrorNotification.tsx
1:import { Transition } from '@headlessui/react';

src/components/UnsavedChangesModal.tsx
1:import { Dialog } from '@headlessui/react';

src/components/header/Notifications.tsx
1:import { Transition } from '@headlessui/react';

src/components/segments/ConstraintForm.tsx
1:import { Dialog } from '@headlessui/react';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Halp ui v2 For consideration for v2 of Flipt
Projects
Status: No status
Development

No branches or pull requests

2 participants