Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When uploading an empty file the progress function report incorrect value #302

Open
evilaliv3 opened this issue Jul 10, 2020 · 4 comments
Open

Comments

@evilaliv3
Copy link
Member

I just tried to load an empty file and i nocided that the progress() function continues to report 0 after completion of the upload.

@AidasK: I've still to look at the code but maybe you have already an idea about this possible errore

@AidasK
Copy link
Member

AidasK commented Jul 10, 2020

https://github.com/flowjs/flow.js/blob/master/src/flow.js#L571 🥇 It should return 1 if request was made. It's a bug

@evilaliv3
Copy link
Member Author

What do you think should be the right fix without refactoring the whole code?

@AidasK
Copy link
Member

AidasK commented Jul 11, 2020

I might be wrong, but it might not be a bug in place I pointed above. Chunk requests actually are always bigger than 0 bytes even though file uploaded is 0 bytes. This is because request contains headers. You should test out each progress function in flow.js to find which part might cause this issue. There are 3 progress functions: chunk, file and total. Try adding some breakpoints and fixing one should fix the others as well.

@PhilippEichhorn
Copy link

PhilippEichhorn commented Sep 22, 2020

Hi, is there any solution for this "bug" ?
im stuck with the same error

@evilaliv3 did you find any solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants