Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions: More flexibility for headers, footers and cover images #10

Open
wingkinl opened this issue May 8, 2023 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@wingkinl
Copy link
Contributor

wingkinl commented May 8, 2023

First of all, thanks for creating this great theme! I have a couple of suggestions that could make the theme even more flexible and user-friendly:

  1. Allow hiding or customizing the header and footer. As a user, I would like the option to hide the header and footer on some pages, or customize them with my own HTML. This added flexibility would be greatly appreciated.
  2. Allow using relative paths for cover images. The "cover" key currently seems to only accept full URLs to images. It would be handy if relative image paths could also be used, so that I can reuse images in my /static/ folder or the same level of the md files.
  3. Allow using relative paths for images. Same as above. I put my content files under the same directory, so .md and .jpg etc. are in the same level. It seems that iTheme only support image paths relative to /static directory.

Thanks again for your work on this theme.

@floyd-li
Copy link
Owner

floyd-li commented May 9, 2023

thanks for your suggestion!

Allow hiding or customizing the header and footer. As a user, I would like the option to hide the header and footer on some pages, or customize them with my own HTML. This added flexibility would be greatly

i don't think it is necessary. since Hugocreate static files based on the markdown files. i'm not sure it is possible tocustomize them with my own HTML.

for relative path support, yes i'll consider to add it as new feature in the future.

@wingkinl
Copy link
Contributor Author

wingkinl commented May 9, 2023

i'm not sure it is possible tocustomize them with my own HTML.

There's a great theme called DoIt and it allows customization on almost everything on the pages, you may want to have a look if you plan on making iTheme even better: https://hugodoit.com/theme-documentation-basics/#site-configuration

@wingkinl wingkinl mentioned this issue May 12, 2023
@floyd-li
Copy link
Owner

floyd-li commented Jun 4, 2023

i'm not sure it is possible tocustomize them with my own HTML.

There's a great theme called DoIt and it allows customization on almost everything on the pages, you may want to have a look if you plan on making iTheme even better: https://hugodoit.com/theme-documentation-basics/#site-configuration

aya. just checked it and it's really a great theme! i may need more work to make this theme much better!

@floyd-li floyd-li added the enhancement New feature or request label Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants