-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitLab Provider adds commit status for every reconciliation #1009
Comments
mo-rieger
pushed a commit
to mo-rieger/notification-controller
that referenced
this issue
Dec 19, 2024
mo-rieger
pushed a commit
to mo-rieger/notification-controller
that referenced
this issue
Dec 19, 2024
mo-rieger
pushed a commit
to mo-rieger/notification-controller
that referenced
this issue
Dec 20, 2024
RESOLVES fluxcd#1009 Signed-off-by: Moritz Rieger <[email protected]>
Can someone please take a look at the PR? |
mo-rieger
pushed a commit
to mo-rieger/notification-controller
that referenced
this issue
Jan 31, 2025
RESOLVES fluxcd#1009 Signed-off-by: Moritz Rieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The GitLab Provider continuously adds commit statuses for every reconciliation.
This happens only for projects with more than 20 jobs. The GitLab Provider code already has some logic to prevent adding a commit status if one already exists. Still, it only considers the first 20 commit statuses because it is a paginated request that defaults to 20.
The impact of this bug is quite heavy. Thousands of commit statuses considered "external jobs" in the GitLab UI have piled up, with every new job triggering some GitLab background processes, nearly bringing down our GitLab instance.
The text was updated successfully, but these errors were encountered: