Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out the Witness node UX #175

Open
davissp14 opened this issue Mar 20, 2023 · 4 comments
Open

Figure out the Witness node UX #175

davissp14 opened this issue Mar 20, 2023 · 4 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request flyctl PG related issues related to flyctl. good first issue Good for newcomers pg:adaptability Helps Fly Postgres to grow with users pg:efficiency Helps Fly Postgres to get more efficient

Comments

@davissp14
Copy link
Contributor

davissp14 commented Mar 20, 2023

The witness node is now functionally available, but there are a few things that need to be addressed before exposing it.

  1. A 2+1 provision option needs to be added to flyctl along with the ability to provision a witness machine.
  2. We should consider adding a one-off flyctl command that allows users to add a witness node to their existing setup.
  3. We need formal documentation going over the witness node and when/how it should be used.

Witness machine spec

  • Same image as a normal member.
  • WITNESS environment variable needs to be set.
  • Minimal resource allocations. 1GB volume, 256mb memory, 1 cpu, etc.
@davissp14 davissp14 added documentation Improvements or additions to documentation enhancement New feature or request flyctl PG related issues related to flyctl. labels Mar 20, 2023
@guillaumervls
Copy link

Can we set the machine resources (disk, cpu, memory...) with fly machine clone? If so we can do 2. with it, right?

@davissp14
Copy link
Contributor Author

Can we set the machine resources (disk, cpu, memory...) with fly machine clone?

We cannot. The fly machine clone will duplicate the spec of the target machine. This is great for horizontally scaling members, but we wouldn't be able to use it to spin up a witness. You could in theory spin-up two witnesses, but it wouldn't provide any real value. That being said, it would probably make sense to restrict apps to a single witness.

@guillaumervls
Copy link

This can help superfly/flyctl#1938

@guillaumervls guillaumervls added pg:adaptability Helps Fly Postgres to grow with users pg:efficiency Helps Fly Postgres to get more efficient good first issue Good for newcomers labels Mar 30, 2023
@Ederene20
Copy link
Contributor

Hi @davissp14! Can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request flyctl PG related issues related to flyctl. good first issue Good for newcomers pg:adaptability Helps Fly Postgres to grow with users pg:efficiency Helps Fly Postgres to get more efficient
Projects
None yet
Development

No branches or pull requests

3 participants