fix(efb): fix checklists not turning green if completed but not in the relevant flight phase

[Fabi-02]

Fixes #8783

Summary of Changes

If checklists are completed, they are now turning green, even if the plane is not in the relevant flight phase.
Additionally, the checklists that have not been completed yet gets a bit faded if they belong to a non-relevant flight phase.

Screenshots

References

N/A

Additional context

Discord username (if different from GitHub): xaliburmc

Testing instructions

Check the correct behavior of the checklist tabs on the EFB.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, find and click on the PR Build tab
4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

[2hwk]

This feels like it could create more bugs than what it's attempting to fix, I'd caution that this would require a bit of testing.

[Fabi-02]

Could be. What was the initial reason for only highlighting the checklists of the relevant flight phase?

[2hwk]

Approved for now code wise, but needs some scrutiny on testing.

EDIT: One modification could be to check if it is in a current or previous flight phase, but not a flight phase that has yet to be entered.

[2hwk]

Quality Assurance Tester Report

Discord Username: 2cas
Object of testing: #8785
Aircraft: A32NX
Tier of Testing: 1
Date: 16/11/2024

Testing Process:

• Tested that checklists work in their intended flight phase
• Tested that checklists work out of their intended flight phase

Taxi checklist unchecks itself on ground after turning off PRED WIND SHEAR.

Testing Results:
Not Passed

Negatives:

• Doesn't appear to fix the bug listed and creates a new bug noted above.

Conclusions:

• Back to the drawing board I think for this one.

[Benjozork]

@Fabi-02, are you still planning to work on this?