-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a380x): new camera angles #9079
base: master
Are you sure you want to change the base?
feat(a380x): new camera angles #9079
Conversation
mistake, let's keep it open |
UITitle="PFD/ND" | ||
Title="5" | ||
Guid="{F8DA40F6-7E12-484D-99E6-BE4DCE962883}" | ||
UITitle="Passenger View Window Flaps" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably still want to use localization strings for this, just maybe our own instead of what is provided from the sim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can use it; I think it's better for us to use our own strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have our own loc pac for the A380 and the localazy system so they can get translated to the various languages https://github.com/flybywiresim/aircraft/tree/master/fbw-a380x/src/localization/msfs
[VIEWS] | ||
eyepoint = 44.2, -1.72, 4.15 ; (feet) longitudinal, lateral, vertical distance from reference datum | ||
|
||
[CAMERA_RAY_NODE_COLLISION] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be kept as well 👍
@@ -1,1662 +1,357 @@ | |||
; Copyright (c) 2023-2024 FlyByWire Simulations | |||
; SPDX-License-Identifier: GPL-3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the SPDX + copyright claim.
The camera "PilotVR" is essential for the viewpoint in virtual reality (VR) and it should be kept as is (but can get a new number of course). There have been already two PRs to tune that view point. |
XYZAcceleratorTime =0 | ||
|
||
[CAMERADEFINITION.39] | ||
Title="PilotVR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This camera (PilotVR) needs to be kept with the original values, but a new number can be assigned. Maybe it's even a good idea to give it a very low number as it's an essential camera.
@SpaceTechAviation Are you still planning to work on this? |
Fixes #[issue_no]
Summary of Changes
• I modified the camera angles to improve perspective and user experience.
• I standardized the "Utitle" to align with the simulator’s configuration, where the cameras are mapped to the numeric keypad for easier navigation.
• Additionally, I updated the "UItitle", removing the number it had before, and added a "Description" with the name of the specific location for each camera view, making it easier to understand the position of each camera.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.