Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380/fcu): fixing speed overlap on light test #9129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thomasshrm
Copy link
Contributor

Fixes #9091

Summary of Changes

Move the box a little to the left (-1%), after the test, you can also try 4% instead of 5% if the overlap is still present.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): tommytknuckles

Testing instructions

Perform a light test
Check SPEED value on FCU and make sure the 8 from speed don't overlap with KTS

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@beheh beheh added the A380X Related to the A380X aircraft label Oct 25, 2024
@tracernz tracernz added this to the v0.13.0 milestone Oct 26, 2024
@tracernz
Copy link
Member

Can you provide screenshots with PRs that make graphical changes please?

@2hwk
Copy link
Member

2hwk commented Nov 15, 2024

Quality Assurance Tester Report

Discord Username: 2cas
Object of testing: #9129
Aircraft: A380X
Tier of Testing: 1
Date: 15/11/2024

Testing Process:

  • Perform a light test
  • Check SPEED value on FCU and make sure the 8 from speed don't overlap with KTS - Failed, still overlaps

Testing Results:
QA Not Passed

Negatives:

  • KTS still overlaps 8.

@tracernz
Copy link
Member

The issue is not actually the knots; it's the digits moving, and the . not getting the right kerning.

@Benjozork
Copy link
Member

@thomasshrm Are you still planning to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

A380X/FCU: Light test speed window overlap
6 participants