Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380/mfd): FLT NBR is now displayed as a mandatory input field #9765

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jet2code
Copy link

@jet2code jet2code commented Jan 16, 2025

Fixes #9752

Summary of Changes

  • Set atcCallsign's initial value to null to ensure it met the criteria for displaying mandatory boxes in InputField
  • This displays the FLT NBR input field as mandatory. CPNY RTE was left as is as it is currently a disabled field.

Screenshots (if necessary)

Screenshot_2267

References

image

Additional context

Discord username: john.xyz

Testing instructions

  1. Open the INIT page
  2. Ensure FLT NBR has mandatory input symbology

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks. Do you happen to have a reference image showing the A380 FMS? Yours shows an A350.

.github/CHANGELOG.md Outdated Show resolved Hide resolved
@jet2code
Copy link
Author

Good spot, thanks. Do you happen to have a reference image showing the A380 FMS? Yours shows an A350.

The reference was from the issue that was posted so I am not sure but I did confirm a reference from the A380 here. I will update the changelog as soon as possible.

image

@flogross89
Copy link
Contributor

Ah, and one more thing. If atcCallsign is null, the callsign in the upper right should display the dashes instead of being blank.
You need to change this in AbstractHeader.tsx, line 111:
{this.props.callsign} to {this.props.callsign.map((cs) => (cs !== null ? cs : '---------'))}

@jet2code
Copy link
Author

Ah, and one more thing. If atcCallsign is null, the callsign in the upper right should display the dashes instead of being blank.

You need to change this in AbstractHeader.tsx, line 111:

{this.props.callsign} to {this.props.callsign.map((cs) => (cs !== null ? cs : '---------'))}

Yeah, I did notice this in the video I sent. I'll get that detail in as well.

@jet2code
Copy link
Author

jet2code commented Jan 17, 2025

Just pushed the latest changes.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔴 Code Review: In progress
Development

Successfully merging this pull request may close these issues.

MFD: amber boxes not displayed in Flight Number field and CPNY RTE field on INIT A Page before initialisation
2 participants