feat(a380x/oans): EXIT missed, flags/crosses, visual fixes #9725

flogross89 · 2025-01-06T19:47:31Z

Fixes #9672
Fixes #9514
Fixes #9798

Summary of Changes

Out of scope:

LDG SHIFT

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Build: https://www.swisstransfer.com/d/64a37f95-7134-41e4-a725-f8154c196e90 (use this instead of the GitHub build)

Confirm that issues are solved
BTV: Perform landing, select exit before DRY line. "EXIT MISSED" should appear in the FMA once it becomes clear that the exit will be missed (confirmation time: 5 seconds)
Select different runway, taxiways and parking stands through the MAP DATA tab, "CENTER MAP ON xxx" should work
Adding flags and crosses to taxiways should work: One symbol at least every 250m, on each of the taxiway lines
Addings flags and crosses should be possible via the context menu: Double click on desired location in the ND, select "ADD x"
Pull ARPT NAV reset knob in overhead reset panel, OANS should be disabled

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the left side, find and click on the PR Build tab
Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

fbw-a380x/src/systems/instruments/src/ND/oans-style.scss

Benjozork · 2025-01-20T18:15:54Z

...e/flybywire-aircraft-a380-842/SimObjects/AirPlanes/FlyByWire_A380_842/model/A380_COCKPIT.xml

@@ -4982,6 +4982,9 @@
                </Component>

                <Component ID="Overhead_Reset_Panel">
+                <UseTemplate Name="FBW_Airbus_RESET_PANEL_BUTTON">


We should probably extract this to its own .xml file at some point, like other newer behaviours. Probably not in this PR though

Agree, makes sense to tackle this in a dedicated PR

# Conflicts: # fbw-a380x/src/systems/instruments/src/ND/OansControlPanel.tsx # fbw-a380x/src/systems/instruments/src/ND/instrument.tsx

# Conflicts: # .github/CHANGELOG.md

Benjozork · 2025-01-20T18:16:28Z

fbw-a380x/src/images/oans/oans-cross.svg

Are those images meant to be duplicated?

I converted these to png to improve performance after a request from tracer, but wanted to keep the SVG source files.

fbw-a380x/src/systems/instruments/src/MFD/pages/common/MouseCursor.tsx

Benjozork · 2025-01-20T18:17:07Z

fbw-a380x/src/systems/instruments/src/MFD/pages/common/MouseCursor.tsx

+    true,
+  );
+
+  private readonly fillColor = this.color.map((c) => (c === MouseCursorColor.MAGENTA ? '#ff94ff' : '#ffff00'));


Leaked subscription

Benjozork · 2025-01-20T18:18:41Z

fbw-a380x/src/systems/instruments/src/ND/OansControlPanel.tsx

@@ -141,12 +178,18 @@ export class OansControlPanel extends DisplayComponent<OansProps> {
    this.pposLongWord,
  );

+  private readonly setPlanModeDisplay = ConsumerSubject.create(this.sub.on('oans_show_set_plan_mode'), false).map(


Leaked subscription

Could you elaborate a bit on that? Is the .map leaking or the this.sub.on ?

fbw-a380x/src/systems/instruments/src/ND/OansControlPanel.tsx

fbw-common/src/systems/instruments/src/OANC/OancMarkerManager.ts

Benjozork · 2025-01-20T18:27:20Z

fbw-common/src/systems/instruments/src/OANC/OancMovingModeOverlay.tsx

@@ -51,7 +51,7 @@ export class OancMovingModeOverlay extends DisplayComponent<OancMapOverlayProps>
          bus={this.props.bus}
          visible={this.roseModeVisible}
          rotation={this.props.rotation.map((r) => {
-            const word = Arinc429Word.empty();
+            const word = Arinc429Register.empty();


This still allocates an object every time. This is meant to be stored as a class property and updated.

changed it, hope it's better now

fbw-common/src/systems/instruments/src/OANC/OancControlPanelUtils.ts

# Conflicts: # .github/CHANGELOG.md

flogross89 added 2 commits January 6, 2025 05:19

transmit EXIT MISSED from BTV

a7d86fd

add EXIT MISSED

b645b18

flogross89 added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Jan 6, 2025

flogross89 added this to the v0.13.0 milestone Jan 6, 2025

flogross89 added 11 commits January 6, 2025 20:51

make OANS cursor magenta

4083320

add magenta lubber line

ad14e26

prep for flags&crosses

cbd18d2

add SET PLAN MODE

713772c

rename events

7446eda

add CENTER MAP ON xxx

c88d03f

Merge branch 'master' into feat-a380x-oans-flags

546d9ba

add flags/crosses via MAP DATA tab

4b0f871

Merge branch 'master' into feat-a380x-oans-flags

48b83bf

Erase flags/symbols, add them freely, clear all

9e2b47e

strict mode grind

f334ad1

flogross89 force-pushed the feat-a380x-oans-flags branch from ec3c825 to f334ad1 Compare January 10, 2025 03:52

flogross89 added 4 commits January 10, 2025 04:54

changelog

ca262ca

Merge branch 'master' into feat-a380x-oans-flags

e80265f

ARPT_NAV reset panel

c600c4e

move SET PLAN MODE

3c45447

flogross89 marked this pull request as ready for review January 14, 2025 04:25

tracernz reviewed Jan 14, 2025

View reviewed changes

fbw-a380x/src/systems/instruments/src/ND/oans-style.scss Outdated Show resolved Hide resolved

flogross89 added 4 commits January 16, 2025 00:35

change images to pngs

6598157

Merge branch 'master' into feat-a380x-oans-flags

03d8d9c

Merge branch 'master' into feat-a380x-oans-flags

481dbaf

tweak taxiway symbol placement, fix some bug

339c983

flogross89 requested a review from Benjozork January 20, 2025 01:00

Benjozork reviewed Jan 20, 2025

View reviewed changes

Merge branch 'master' into feat-a380x-oans-flags

8d4b2e2

# Conflicts: # fbw-a380x/src/systems/instruments/src/ND/OansControlPanel.tsx # fbw-a380x/src/systems/instruments/src/ND/instrument.tsx

flogross89 added 4 commits January 22, 2025 03:05

remove debug output; use mag bearing for ND runway info

61b1c9b

change control panel arrow symbol when opening

bb5f719

Merge branch 'master' into feat-a380x-oans-flags

197fc3d

# Conflicts: # .github/CHANGELOG.md

make nd_show_oans side-dependant

e9d9c6c

Benjozork requested changes Jan 26, 2025

View reviewed changes

review comments

816ca4c

flogross89 force-pushed the feat-a380x-oans-flags branch from bfb07e2 to 816ca4c Compare January 26, 2025 16:28

flogross89 requested a review from Benjozork January 26, 2025 16:31

flogross89 added 5 commits January 26, 2025 19:14

clean up more subscriptions

e820f45

fix entity types

5981562

Merge branch 'master' into feat-a380x-oans-flags

faa7b20

# Conflicts: # .github/CHANGELOG.md

fix reset mechanism

b0f01fb

introduce unloading failsafe

db8dbd4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(a380x/oans): EXIT missed, flags/crosses, visual fixes #9725

feat(a380x/oans): EXIT missed, flags/crosses, visual fixes #9725

flogross89 commented Jan 6, 2025 •

edited

Loading

Benjozork Jan 20, 2025

flogross89 Jan 21, 2025

Benjozork Jan 20, 2025

flogross89 Jan 26, 2025

Benjozork Jan 20, 2025

Benjozork Jan 20, 2025

flogross89 Jan 26, 2025

Benjozork Jan 20, 2025

flogross89 Jan 26, 2025

feat(a380x/oans): EXIT missed, flags/crosses, visual fixes #9725

Are you sure you want to change the base?

feat(a380x/oans): EXIT missed, flags/crosses, visual fixes #9725

Conversation

flogross89 commented Jan 6, 2025 • edited Loading

Summary of Changes

Screenshots (if necessary)

References

Additional context

Testing instructions

How to download the PR for QA

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flogross89 commented Jan 6, 2025 •

edited

Loading