From b8f38aa66e574a39562eb746b56acab4eed5f3a3 Mon Sep 17 00:00:00 2001 From: Fabian Date: Wed, 31 Jul 2024 10:46:04 +0200 Subject: [PATCH] fix(efb): fix checklists not turning green if completed but not in the relevant flight phase --- .github/CHANGELOG.md | 1 + .../instruments/src/EFB/Checklists/Checklists.tsx | 9 ++++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/CHANGELOG.md b/.github/CHANGELOG.md index 550ef63666e..541db024291 100644 --- a/.github/CHANGELOG.md +++ b/.github/CHANGELOG.md @@ -109,6 +109,7 @@ 1. [MCDU] Fixed ZFW Autofill with lbs during boarding @ShreyasKallingal 1. [FWC] Fix NW STRG DISC turning amber too soon - @adoggman (Andrew) 1. [FMS] Fix VNAV crash for steep approaches - @BlueberryKing (BlueberryKing) +1. [EFB] Fix checklists not turning green if completed but not in the relevant flight phase - @Fabi-02 (Fabi) ## 0.11.0 diff --git a/fbw-common/src/systems/instruments/src/EFB/Checklists/Checklists.tsx b/fbw-common/src/systems/instruments/src/EFB/Checklists/Checklists.tsx index b214ebf40f4..338da511ea4 100644 --- a/fbw-common/src/systems/instruments/src/EFB/Checklists/Checklists.tsx +++ b/fbw-common/src/systems/instruments/src/EFB/Checklists/Checklists.tsx @@ -153,7 +153,7 @@ export const Checklists = () => { const isMarkedCompleted = checklists[index].markedCompleted; const isSelected = index === selectedChecklistIndex; const isIndexRelevant = relevantChecklistIndices.includes(index); - if (isSelected && isChecklistCompleted && isIndexRelevant) { + if (isSelected && isChecklistCompleted) { return isMarkedCompleted ? 'bg-utility-green font-bold text-theme-body' : 'bg-utility-amber font-bold text-theme-body'; @@ -161,14 +161,17 @@ export const Checklists = () => { if (isSelected) { return 'bg-theme-highlight font-bold text-theme-body'; } - if (isChecklistCompleted && isIndexRelevant) { + if (isChecklistCompleted) { return isMarkedCompleted ? 'bg-theme-body border-2 border-utility-green font-bold text-utility-green ' + 'hover:text-theme-body hover:bg-utility-green' : 'bg-theme-body border-2 border-utility-amber ' + 'font-bold text-utility-amber hover:text-theme-body hover:bg-utility-amber'; } - return 'bg-theme-accent border-2 border-theme-accent font-bold text-theme-text hover:bg-theme-highlight hover:text-theme-body'; + return ( + 'bg-theme-accent border-2 border-theme-accent font-bold text-theme-text hover:bg-theme-highlight hover:text-theme-body' + + (!isIndexRelevant ? ' opacity-50 hover:opacity-100' : '') + ); }; /**