Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golang_support_tools to boilerplate #4659

Closed
wants to merge 3 commits into from
Closed

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jan 2, 2024

What changes were proposed in this pull request?

make generate fails to generate the proto file without golang_support_tools.

How was this patch tested?

make generate

Screenshots

(flytekit-3.10) ➜  flyte git:(agent-metric) ✗ make generate
Using temp directory /var/folders/xp/_4ltv_bx3pb_r0bm00fk9z_00000gn/T/gotooling-XXX.C3xwIOs0
cp: boilerplate/flyte/golang_support_tools/*: No such file or directory
make: *** [download_tooling] Error 1

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working housekeeping Issues that help maintain flyte and keep it tech-debt free labels Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba10600) 58.12% compared to head (94c01af) 58.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4659      +/-   ##
==========================================
+ Coverage   58.12%   58.44%   +0.32%     
==========================================
  Files         626       34     -592     
  Lines       53815     2079   -51736     
==========================================
- Hits        31278     1215   -30063     
+ Misses      20035      771   -19264     
+ Partials     2502       93    -2409     
Flag Coverage Δ
unittests 68.09% <ø> (+9.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 3, 2024
@pingsutw pingsutw marked this pull request as draft January 3, 2024 02:04
@Future-Outlier
Copy link
Member

We can generate the proto without this PR, let's make it draft for other usecases.

@eapolinario
Copy link
Contributor

We brought all of boilerplate in #5134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants