Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing SigmetTacElement #173

Open
kasarit opened this issue Sep 26, 2023 · 0 comments
Open

Consider removing SigmetTacElement #173

kasarit opened this issue Sep 26, 2023 · 0 comments
Labels
sigmet/airmet SIGMET/AIRMET issues

Comments

@kasarit
Copy link
Contributor

kasarit commented Sep 26, 2023

I find this class a bit strange. It seems that it is never used in parsing, but only upon reconstruction. But we already have lexemes for TAC geometry that we could use for reconstruction, right? I'd suggest removing this class and use the lexeme reconstructors we already have for this purpose.

But if there's a good reason to retain this class, I'd propose to at least

  • make the outer class empty, without extending or implementing any class (and omit it in any configuration),
  • rename the outer class and lexeme identity related to TAC geometry, and
  • deduplicate handing of SIGMET and AIRMET.

Originally posted by @petringo in #117 (comment)

@kasarit kasarit added the sigmet/airmet SIGMET/AIRMET issues label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sigmet/airmet SIGMET/AIRMET issues
Projects
None yet
Development

No branches or pull requests

1 participant