Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fog::Openstack::Core#request discards headers upon retries #507

Closed
avgerin0s opened this issue Nov 27, 2019 · 0 comments · Fixed by #508
Closed

Fog::Openstack::Core#request discards headers upon retries #507

avgerin0s opened this issue Nov 27, 2019 · 0 comments · Fixed by #508

Comments

@avgerin0s
Copy link
Contributor

This issue seems related to #502 and #501.

After debugging an incident similar to the aforementioned issues I came across f72d2fc which started mutating the params Hash passed by the used in request method (implicitly via the requests classes.

This piece of code will discard the :headers key from the params hash provided by the user on the first request.

In case of a token renewal, for example, the request will the be retried without the headers it used before. Instead it will be dispatched with the default headers (I believe this is why people in the other issues mention wrong Content-Type: application/json).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant